Skip to content

Message Pinning 📌 #5535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rapterjet2004 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Message Pinning 📌 #5535

rapterjet2004 wants to merge 1 commit into from
+1,021 −99

Conversation

@rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Nov 4, 2025 •
edited
Loading

The CI/CD check seems to be broken

🚧 TODO

  • Shared Items support
  • Fixed hiding messages
  • Fix moderation
  • Fix timestamp
  • UI suggestions

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 self-assigned this Nov 4, 2025
@rapterjet2004 rapterjet2004 added the 2. developing Work in progress label Nov 4, 2025
@rapterjet2004 rapterjet2004 marked this pull request as ready for review November 17, 2025 16:15
@rapterjet2004 rapterjet2004 force-pushed the issue-5534-message-pinning branch from 32d678e to 9a043b0 Compare November 19, 2025 13:36
@rapterjet2004 rapterjet2004 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 21, 2025
@mahibi mahibi added this to the 23.0.0 milestone Nov 27, 2025
@mahibi
Copy link
Collaborator

mahibi commented Nov 27, 2025

@rapterjet2004 as there is a chance that checks succeed now, can you rebase? Might be there will some merge conflicts..

mahibi
mahibi requested changes Nov 28, 2025
View reviewed changes
Copy link
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just rejecting for now to not merge before a potential v22.1.0 branchoff...

@rapterjet2004 rapterjet2004 force-pushed the issue-5534-message-pinning branch from 27d4daa to 0a1c0e8 Compare December 1, 2025 14:40
@rapterjet2004 rapterjet2004 requested a review from mahibi December 2, 2025 14:42
mahibi

This comment was marked as resolved.

Sign in to view

sowjanyakch

This comment was marked as resolved.

Sign in to view

@mahibi mahibi modified the milestones: 22.1.0, 23.0.0 Dec 18, 2025
@rapterjet2004 rapterjet2004 force-pushed the issue-5534-message-pinning branch from 0a1c0e8 to 93ae440 Compare December 22, 2025 20:15
@rapterjet2004
Added Pinned Messages Support
98bb053 
- ChatMessage now has ChatMessageMetaData
- Conversation now has updated fields from server
- Added PinnedMessageOptionsDialog
- Added as type to Shared Items
- API, viewmodel, class functions

Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@rapterjet2004 rapterjet2004 force-pushed the issue-5534-message-pinning branch from eb15b60 to 98bb053 Compare December 30, 2025 14:16
@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5535.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2025

Codacy

Lint

TypemasterPR
Warnings9999
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

@mahibi
Copy link
Collaborator

mahibi commented Jan 9, 2026

looks much better now 👍

  • go to message should show the message centered. Else it is on top and overlayed by the pinned message box itself.

  • additionally it also makes sense to scroll to the message when just tapping the pinned message.

  • scroll to only works if the have the message load in the adapter. Maybe (until we have a better solution in the future..) we should show the message search results window if it was not found in adapter?

  • on server the string is "until unpin". on android "Pin indefinitely". please align.

  • the custom date dialog borders are not transparent but colored wrong:

grafik
  • in the attachments overview, clicking on a pin should not delete it but open the chat and scroll to it. At best would be an option to delete it (like in web)
grafik

  • if possible, make it reactive to directly show updated pinned messages whenever they change (when system message is received). right now, when a change is done on web, it's just updated when reloading the chat or waiting for the next pull.

  • on web, there is a pin shown inside the chat for the pinned messages. would be nice to also have this for mobiles.

grafik

mahibi
mahibi requested changes Jan 9, 2026
View reviewed changes
Copy link
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

mahibi
mahibi reviewed Jan 9, 2026
View reviewed changes
app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt

val pinnedBy = stringResource(R.string.pinned_by)

// FIXME this causes some problems with duplicate some times
Copy link
Collaborator

@mahibi mahibi Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • todo before merging?..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi mahibi requested changes

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

Requested changes must be addressed to merge this pull request.

Assignees

@rapterjet2004 rapterjet2004

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

23.0.0

Development

Successfully merging this pull request may close these issues.

Implement Message Pinning 📌

4 participants

@rapterjet2004 @mahibi @sowjanyakch